Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow alias verification token/alias atomicity containment only. Verification holds the token lock through the alias write, ownership/evidence checks, and checked terminal token transition in one PostgreSQL transaction. Pre-commit failures roll back without an independent token reset; successful verified replay validates persisted evidence. The GET expiry update cannot regress a terminal token.
This is a DRAFT stacked on #7463, with base
conductor/member-email-reconciliation-592atcdef5b8e0c2dd45da9cb97cc29261ff654c1c08d. Publication is authorized for this exact reviewed candidate only; human approval and fresh exact-head CI are required. A maintainer review request is not approval. Do not mark ready, merge, enable auto-merge, or deploy on the strength of this Draft.Scope and release limits:
592_email_mutations.sql) is preserved byte-for-byte, blobe726bbaaa214105df6a922773f7c208bb4919966in both parent and candidate. No migration number is allocated by this PR.users.emailwriters and alias claims. The users-email recheck does not establish a DB-wide normalized-email invariant. Separate migration 595 work for that invariant is in progress and is not included here.main.Immutable candidate:
8847fc96d5504dcab4138ccb90bad280f385ea311b403c12f056415c2dd02a7bbbcd0264c841937dcdef5b8e0c2dd45da9cb97cc29261ff654c1c08d773728362a530bdf0274e008452cd17368957f9ada457a3d55fe35c1410109a56e153ffe347e352bconductor/alias-verification-atomicityExact commit · Exact parent-to-head diff
Exactly one feature commit and three changed files: 477 insertions, 55 deletions. No reviewed blob was rebased or changed for publication.
server/src/routes/account-linking.tscfcf3a65b0dc11afb9568802aa943b9ca366293eab283d29b754dd083d31c645a49ef56fbb94e2daserver/tests/integration/alias-verification-atomicity.test.ts0cef113161f9bed39a9c52e1f67d0f555771098bserver/tests/unit/set-primary-email.test.tsac61fc833469e745378a5e4a2baa4bc6f56c5dc3344a6b1eee24f63f509ac1f9d521d0d4b1ee7fb8Validation on the unchanged candidate:
Total unit passes are 10,706. Focused/selection runs overlap the full suites and are not added again. Integration skips comprise one opt-in retained-GCS-evidence test and seven opt-in creative-agent comparisons. PostgreSQL 16 validation used disposable local Docker databases on loopback port 55432. The focused suite covers independent-session races and deterministic barriers, same-token replay, competing aliases, legacy state, current credential conflicts, INSERT/UPDATE exceptions and suppressed writes, cardinality tampering, persisted-state trigger tampering, rollback observations, and stale GET expiry. Provider credential methods were mocked and asserted unused.
Diagnosed baseline/harness behavior is retained in the evidence:
persistence_uncertain. Diagnostics captured PostgreSQL SQLSTATE 55P03 at itsSHARE ROW EXCLUSIVEtable lock with a 250 ms lock budget. This race failure also reproduced on the clean exact parentcdef5b8e0c2dd45da9cb97cc29261ff654c1c08d(tree773728362a530bdf0274e008452cd17368957f9a). The full initialized batch-3 retry subsequently passed all 36 ledger tests. No ledger code, migration, or test repair is included here.Independent exact-head review:
The separate read-only reviewer
/root/security_reviewverified the exact head/tree/parent/patch and changed blobs, inspected transaction/lock lifecycle and fault/replay paths, and independently checked the actual test logs, all 167 distinct integration files, strict typecheck exit 0, and the exact-parent 55P03 reproduction. The reviewer made no edits or database mutations. This narrow verdict does not establish the broader claims explicitly excluded above, replace human approval, or waive fresh exact-head CI.Prior local logs and the review are retained in the publication workspace's gitignored
.context/:commit-validation.log,alias-focused.log,reconciliation.log,final-integration-results.json,integration-1.log,integration-2.log,integration-3-retry.log,integration-4.log,test-typecheck-result.json,ledger-lock-diagnostic.log,ledger-exact-base.log,ledger-baseline-state.json, andsecurity-review.md. These local results are not a claim that fresh GitHub CI has passed. Existing workflow base-branch filters may omit full build/security jobs on this stacked base; all required fresh exact-head CI remains a release gate.Open workspace in Conductor
Draft disposition — 2026-10-09
This draft is retained for the stated workstream. Continue on this existing branch; no parallel PR is needed. This disposition does not waive CI, review, migration, or release gates.